Fix lazynpm command execution and npm link handling for modern Go/npm versions#19
Open
BoxThatBeat wants to merge 1 commit into
Open
Fix lazynpm command execution and npm link handling for modern Go/npm versions#19BoxThatBeat wants to merge 1 commit into
BoxThatBeat wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Details
No commands worked at all — vendor/github.com/creack/pty/run.go set SysProcAttr.Ctty to a parent-process FD. Go 1.20 requires Ctty to be valid in the child process. Every PTY-spawned command (npm install, npm link, npm run build, etc.) silently failed with Setctty set but Ctty not valid in child. Fixed by passing the tty as an ExtraFiles entry and setting Ctty to its child FD index.
LinkedGloballywas always false — IsLinked() compared the raw os.Readlink result (a relative path like ../../../../../home/...) against an absolute package path. They never matched. Fixed by resolving relative symlink targets to absolute paths before comparison."(linked)" text never appeared — linkPathMap() only checked dependencies declared in package.json. npm link creates a symlink in node_modules/ without modifying package.json, so the link was invisible. Fixed by scanning node_modules/ (including scoped @org/ dirs) for actual symlinks on disk.
Global unlink was broken on npm v7+ — handleGlobalLinkPackage used bare npm unlink, which became an alias for npm uninstall (local) in npm v7. Changed to npm rm -g .